Improve check for invalid ICC profiles #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
==========================================
+ Coverage 89.31% 89.32% +0.01%
==========================================
Files 893 893
Lines 38020 38090 +70
Branches 2667 2668 +1
==========================================
+ Hits 33956 34023 +67
- Misses 3267 3269 +2
- Partials 797 798 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes #646
There was no check if the actual data byte array was big enough to be a valid header so it tried to read it which resulted in the exception.
This PR fixes that, adds another check if the array is big enough for the reported profile size and extends the unit test cases.